PDA

View Full Version : listing_browse.php little bug Open-Realty 1.1.4



Anonymous
01-14-2004, 06:44 AM
I don't know if I'm right or not since I haven't slept tonight :P

Open listing_browse.php and go to around line 449.
After

$recordSet = $conn->Execute($sql);

isn't there missing the "compulsory" database query error

if ($recordSet === false)
{
log_error($sql);
}

??

I guess this isn't so important since there's not such big probability that this query will fail, but who knows...

Anonymous
01-14-2004, 02:36 PM
I don't think there is anything wrong there, if you are refering to the "===" operator, then that is found about 20 times in the file which means "identical"

Example: if($a === $b) is TRUE if $a is equal to $b, and they are of the same type. (PHP 4 only)

Correct me if I am wrong.

Anonymous
01-17-2004, 06:16 PM
What I was meaning is that the lines

"if ($recordSet === false)
{
log_error($sql);
}"

where missing, so if there had any kind of error happened with the database query, no notification error would be done. If you had made a look at the file before replying me, you would have seen it.

Anyway, I already knew this isn't a critical bug, but it always a must to check that there are no errors when querying the database.