SVN undefined stuff

[David_1cog]

Not sure if SVN feedback is wanted ... here goes anyway (I would've added this to bug tracker but it just keeps telling me "Stop hacking your cookies, you naughty fellow!" :rolleyes: ):

I've just upgraded 2.0.2 to latest SVN and hit the following:

1. from admin Configuration page:

Notice: Undefined index: number_decimals_number_fields in /home/user/public_html/include/controlpanel.inc.php on line 732

Notice: Undefined index: number_decimals_number_fields_desc in /home/user/public_html/include/controlpanel.inc.php on line 734

Notice: Undefined index: number_decimals_price_fields in /home/user/public_html/include/controlpanel.inc.php on line 737

Notice: Undefined index: number_decimals_price_fields_desc in /home/user/public_html/include/controlpanel.inc.php on line 739

2. from home page:

Notice: Undefined offset: 1 in /home/user/public_html/include/class/template.inc.php on line 84

Notice: Undefined offset: 1 in /home/user/public_html/include/class/template.inc.php on line 84

where line 84 =


return $section_results[1];

3. from most other pages (e.g. /view_favorites.html, /saved_searches.html, etc.) I get

The XML page cannot be displayed
Cannot view XML input using XSL style sheet. Please correct the error and then click the Refresh button, or try again later.

--------------------------------------------------------------------------------

Only one top level element is allowed in an XML document. Error processing resource 'http://www.domain.co.uk/calculator....

<b>Notice</b>: Undefined offset: 1 in <b>/home/user/public_html/include/class/template.inc.php</b...

This is caused by adding XML prolog to main.html ("<?xml version="1.0" encoding="iso-8859-1"?>"). With 2.0.2 I had to use PHP echo to output this line and it worked OK. 2.0.3 SVN has broken it for some reason.

4. /include/editor.inc.php (line 265) reads:

value\"yes\"
which should be:

value=\"yes\"

[greengiant]

1.
You need to run the installer and choose update to 2.0.3.

2-3.
Sounds like the search page template was not updated, I have modified svn now, so it should still support old search page templates.

4.
Thanks, this is fixed now.

[David_1cog]

Thanks, Ryan, all fixed with latest SVN except still seeing in admin Configuration:

Notice: Undefined index: number_decimals_number_fields in /home/user/public_html/include/controlpanel.inc.php on line 732

Notice: Undefined index: number_decimals_number_fields_desc in /home/user/public_html/include/controlpanel.inc.php on line 734

Notice: Undefined index: number_decimals_price_fields in /home/user/public_html/include/controlpanel.inc.php on line 737

Notice: Undefined index: number_decimals_price_fields_desc in /home/user/public_html/include/controlpanel.inc.php on line 739


I have run install / update and admin shows '2.0.3'. Entirely possible I've FUBARed something but any suggestions?

[David_1cog]

Sorry, Ryan - it was my fault - hadn't merged lang.inc.php correctly. AOK now :).

P.S. Couple of spelling / typos in en/lang.inc.php:
'infomation'
'modifed'
'turst'
'formating'
'nonexistant'

[greengiant]

David,

Thanks all fixed they will be in teh 2.0.3 release today.

[David_1cog]

Just to drag this out a bit longer ;) ... I've also updated lang.inc.php to be consistent for text delimiter, e.g. sometimes it's:

$lang['addons'] = "Ryan's text says \"hello\"";
and sometimes:

$lang['addons'] = 'Ryan\'s text says "hello"';
I've converted all to:

$lang['addons'] = "Ryan's text says \"hello\"";
along with a few rewordings to help (in my mind) clarity / brevity.

Also, I thought it made more sense for the language strings to contain ':' where appropriate, instead of having them embedded in template files. Users can then control all display characters from the language files.

If you'd like a copy I'll zip it over.

[greengiant]

send it over to ryan at transparent-tech.com, it wont make 2.0.3 a this point but I will get it into svn for the next release.

[David_1cog]

sent
(this forum won't let me enter just four characters :rolleyes: )