Fix for Checkbox Distinct Values OR Logic

[jennifer]

I was having a problem with the or logic search not working for the checkboxes distinct values in version 2.5.6. I edited the search.inc.php to add _or to the checkbox name. I have tested this with version 2.5.6 and with CMS Realty. Here is the revised code for case 'checkbox_or':

case 'checkbox_or':
    $display .= '<tr><td class="searchpage_field_caption">'.$browse_caption.'</td>';
    $display .= '<td align="left">';
    while (!$recordSet->EOF) {
        $field_output = $misc->make_db_unsafe ($recordSet->fields['listingsdbelements_field_value']);
        $num_type = '';
        if ($config['configured_show_count'] == 1) {
            $num_type = $recordSet->fields['num_type'];
            $num_type = "($num_type)";
        }
        if($dateFormat==TRUE){
            $display .= '<input type="checkbox" name="'.$browse_field_name.'_or[]" value="'.$field_output.'" />'.date($format,$field_output).' '.$num_type.'';
            $display .= $config['search_list_separator'];
        }else{
        if ($field_type == 'number')
            {
            $field_display = $misc->international_num_format($field_output, $config['number_decimals_number_fields']);
            $display .= '<input type="checkbox" name="'.$browse_field_name.'_or[]" value="'.$field_output.'" />'.$field_display.' '.$num_type.'';
            $display .= $config['search_list_separator'];
            } else {
            $display .= '<input type="checkbox" name="'.$browse_field_name.'_or[]" value="'.$field_output.'" />'.$field_output.' '.$num_type.'';
            $display .= $config['search_list_separator'];
            }

        }
        $recordSet->MoveNext();
    } // end while
    $display .= '</td></tr>';
    break; 

[ebmarques]

Hi jennifer,

In fact it is a bug and you could also open a Bug Report - but not needed anymore.
I have just fixed it at SVN (rev.2395). With the next O-R release (after v.2.5.6) it will be implemented by default. I gave the credits to you.

Thanks,
Eduardo

[bownut]

Jennifer ... thanks for posting this fix. I just changed to the checkbox search and didn't even realize I had the issue until I read your post. The fix is working for me!

[jennifer]

Great! I am glad I contribute a tiny bit to this great project.