V1.1.2 Generic template is broken - FIXED 1.1.3

[the_sandking]

After a bone-stock install and everything working:

I switched to the generic template, and now the site displays all blank pages.. /ADMIN pages are unaffected..

(The little dot that usually appears when I screw something-up is absent as well)

Oddly enough, if you do a <view> <source> in IE, it looks like all the HTML is there..

Weird.. :shock:

-sk-

[the_sandking]

The problem is in 'in user_bottom.html'


You created a condition where

if ($printer_friendly != "yes")
{
output some HTML
}

But you did not handle the situation:

if ($printer_friendly = "yes")

also, the </html> happens too soon, and when the 2nd set of timing statistics appears after the </html>, the browser becomes confused clientside...

I fixed mine, hope it makes sense..

-sk-[/code]

[marb]

how do you fix the file because I'm working also with the generic menu.

I just replace the new bottom.html with the version before, it is work now
but I dont no of that is the good way.

marten

[the_sandking]

In the end I just used my old file too..

The file you need to be careful with is 'user_top.html' Compare it to your old user_top.html file and you will see where Ryan added the timer code to the top.. Move that timer code to the top of your old user_top.html if you care to see the page load times that are hidden in the source.


Or you can also just eliminate the check to see if the page is printer-friendly.. Me, I really don't care if my home page is printer-friendly, it's the pages with listings on them that count. :wink:


-sk-

[marb]

Thanks for the advice, I will try that.
I'm also install the ful mod and there is no problem to see.
Works fine!

marten

[grapeape]

I have this same problem in version 1.1.3. It doesn't show up in Internet Explorer 6.0 but does show up in Netscape 7.1.

I haven't determined why this is happening yet but I do know which line you can delete to make your page viewable. If you remove the following line, which is in template/generic/user_bottom.html, then it'll show up again.

echo "<!--This page was generated in $&#123;render_time&#125; microseconds--><p>";

Mine displays:

<!--This page was generated in -1062447398.9897 microseconds-->

Obviously there is a problem if the page was created in a negative amount of time. Then again, maybe you're supposed to just ignore the negative number and check out the microseconds.

I suggest we try to change the way the page load time is calculated. I noticed that the current way is the same as the example in the PHP manual. Someone noted that there is a typo in it. I made the correction in my PHP code but still got a negative number (and the page still didn't show up). Someone else noted that this is a poor way to calculate execution time. There are many examples at http://us2.php.net/microtime which might be better. What do you think?

[greengiant]

I must have forgot to fix the render time in the generic template. It is correct in the vertical, you can steal the code from there. It is in the user_top.html and user_bottom.html files

[grapeape]

I must have forgot to fix the render time in the generic template. It is correct in the vertical, you can steal the code from there. It is in the user_top.html and user_bottom.html files

Thanks for the update! I've butchered my generic template so it'll be tough to stick that back in. I know there were other people who posted that they had problems with this so maybe they can try this out to make sure it works. Either way, I guess we'll find out for certain in the next release.